Overall package size

Self size: 4.74 MB
Deduped: 61.21 MB
No deduping: 61.25 MB

Dependency sizes

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

Codecov Report

Merging #3284 (67debdb) into master (6810871) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   86.04%   85.94%   -0.10%     
==========================================
  Files         200      200              
  Lines        7787     7806      +19     
  Branches       33       33              
==========================================
+ Hits         6700     6709       +9     
- Misses       1087     1097      +10     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Benchmarks

Comparing candidate commit 67debdb in PR branch run-stores with baseline commit 6810871 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 459 metrics, 33 unstable metrics.

I haven't been able to figure out why this is now failing. This PR probably conflicts with #3261 after rebasing. The _computePeerService field on the tracer isn't truthy and getPeerService isn't able to pull out the necessary tags. Here's the error itself:

     AssertionError: expected { '_dd.p.dm': '-1', …(11) } to have property 'peer.service'

Which fails within the withPeerService call in packages/datadog-plugin-http2/test/client.spec.js.

The issue with peer.service is we're relying on in OutboundPlugin:finish to be called to make the peer service computation. This used to be the case because we only had start/error/finish - since we move http2 to not call finish, we don't get peer service.

I see 2 options for restoring it

1. include the peer service logic in the new span closing hooks (for example in _onClose in http2, or provide default implementation for _onClose in plugin override it in outbound, ...)
2. move the peer service logic to the span's finish method - we don't rely on the plugin's state except for precursors. We lose the automatic filtering provided by setting the logic in OutboundPlugin, but it can be replaced by filtering spans based on kind (peer service wants only producer/client spans).